Handle terms with missing attendences correctly.

davorg · Dec 29, 2015 · f11e760 · f11e760
1 parent 4e4062c
commit f11e760
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/Kinza/lib/Kinza/Reports.pm b/Kinza/lib/Kinza/Reports.pm
@@ -27,7 +27,7 @@ get '/form' => sub {
   header 'Content-Disposition' => 'attachment; filename="form.csv"';
 
   my $csv;
-  my $terms = join ',', map { $_->name } $rs{Term}->all;
+  my $terms = join ',', map { $_->name } $rs{Term}->search({}, { order_by => 'seq' })->all;
 
   foreach my $y (schema->resultset('Year')->search({}, {
       order_by => 'id',
@@ -40,9 +40,12 @@ get '/form' => sub {
 
       foreach my $s ($f->students->search({}, { order_by => 'name' })) {
         $csv .= $s->name;
+        my $term_seq = 1;
         foreach my $a ($s->sorted_attendances) {
-          for (1 .. $a->presentation->number_of_terms) {
+          if ($a->presentation->term->seq == $term_seq++) {
             $csv .= ',"' . $a->presentation->course->title . '"';
+          } else {
+            $csv .= ',';
           }
         }
         $csv .= "\n";